[Webkit-unassigned] [Bug 46676] HTMLTreeBuilder's InForeignContent code needs a re-write

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=46676


Adam Barth <abarth at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #71502|review?, commit-queue?      |review-
               Flag|                            |




--- Comment #7 from Adam Barth <abarth at webkit.org>  2010-10-21 17:57:50 PST ---
(From update of attachment 71502)
View in context: https://bugs.webkit.org/attachment.cgi?id=71502&action=review

This looks generally good.  Just some stylistic comments.  Eric should look at this too because he did most of the mixed content work.

> LayoutTests/ChangeLog:19
> +        * html5lib/runner-expected.txt: Since the behavior of InForeignContentMode has changed, the expectations need to be updated. These have been manually verified.

At some point we'll sync with html5lib and rebaseline the expected results.

> WebCore/html/parser/HTMLTreeBuilder.cpp:1141
>          defaultForInitial();
> +        prepareToReprocessToken();

Should we just make the prepare call part of the default call?

> WebCore/html/parser/HTMLTreeBuilder.cpp:1234
> +            prepareToReprocessToken();
>              processStartTag(token);

Can we combine these as reprocessStartTag(token) ?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.