[Webkit-unassigned] [Bug 40841] [Qt] Node that have both an opacity and a transform animation on them seem not to fire

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Oct 21 16:25:26 PDT 2010


https://bugs.webkit.org/show_bug.cgi?id=40841





--- Comment #8 from Sam Magnuson <smagnuson at netflix.com>  2010-10-21 16:25:26 PST ---
(In reply to comment #6)
> (From update of attachment 59438 [details])
> WebCore/platform/graphics/qt/GraphicsLayerQt.cpp:634
>  +              else if (!m_state.drawsContent && m_layer->drawsContent())
> Is this an important differencial?
> 

For the duration of this function, yes. It sync's the two at the end of the function but this conditional just notices that the state has changed and what action to take.

> WebCore/platform/graphics/qt/GraphicsLayerQt.cpp:1194
>  +      virtual AnimatedPropertyID getAnimatedProperty() const = 0;
> We normally do not use get. Maybe just call it animatedProperty()

Fair enough, will rename.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list