[Webkit-unassigned] [Bug 42578] [Qt] DRT sideeffect revealed by r63657

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=42578





--- Comment #21 from Robert Hogan <robert at webkit.org>  2010-10-21 13:54:55 PST ---
(In reply to comment #20)
> (In reply to comment #19)
> > > I worry about the performance regression a little bit. Can we make it faster?
> > 
> > This was the only way I could think of.
> 
> You're right, that's currently the only way. There is clearly a function missing in QNetworkAccessManager to clear the cache.
> 
> Actually, isn't there a way to make QWebPage::setNetworkAccessManager() work? What's the problem with using that instead?
> 

I tried that, but it crashed a lot. Then I read:

http://doc.qt.nokia.com/4.6/qwebpage.html#setNetworkAccessManager

"Note: It is currently not supported to change the network access manager after the QWebPage has used it. The results of doing this are undefined."

And gave up!

> How long does the DRT run take for you with and without your change, i.e. what's the performance impact?

Ossy says it takes about a minute extra to perform the entire set of layout tests, so definitely slower.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.