[Webkit-unassigned] [Bug 45597] [GTK] Complex text does not have full CSS text-shadow support

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=45597





--- Comment #3 from Martin Robinson <mrobinson at webkit.org>  2010-10-21 11:42:54 PST ---
(In reply to comment #2)
> (From update of attachment 71211 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=71211&action=review
> 
> > WebCore/platform/graphics/gtk/FontGtk.cpp:66
> > +typedef GdkRegion* cairo_region_t*;
> I think this definition is not correct, it should be:

Nice catch. I'll fix that.

> > WebCore/platform/graphics/gtk/FontGtk.cpp:224
> > +    FloatPoint totalOffset(point + shadow->m_offset);
> Doesn't point include the shadow offset already?

It doesn't. The point passed in is the origin of the baseline of the first solid character.

> > WebCore/platform/graphics/gtk/FontGtk.cpp:236
> > +        cairo_translate(context, -totalOffset.x(), -totalOffset.y());
> Is this required after doing the cairo_restore in the next line?

It isn't! I'll fix that.

> > WebCore/platform/graphics/gtk/FontGtk.cpp:-213
> > -    if (to - from != run.length()) {
> > -        // Clip the region of the run to be rendered
> Before we were doing the clip just in case run does cover the whole line, is this intended?

Doing the clipping unconditionally shouldn't hurt anything, but if performance is a concern I can re-add the condition.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.