[Webkit-unassigned] [Bug 48048] [GTK] WebKitWebFrame's load-status is not properly notified to the tests

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=48048


Martin Robinson <mrobinson at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #71415|review?                     |review+
               Flag|                            |




--- Comment #3 from Martin Robinson <mrobinson at webkit.org>  2010-10-21 09:27:00 PST ---
(From update of attachment 71415)
View in context: https://bugs.webkit.org/attachment.cgi?id=71415&action=review

Looks good, though we need another nod from a GTK+ review for the API change.

> WebKit/gtk/WebCoreSupport/FrameLoaderClientGtk.cpp:596
> +

I think the extra line can be removed.

> WebKit/gtk/WebCoreSupport/FrameLoaderClientGtk.cpp:1136
> +    notifyStatus(m_frame, WEBKIT_LOAD_PROVISIONAL_FAILED);
> +

Same here.

> WebKit/gtk/WebCoreSupport/FrameLoaderClientGtk.cpp:1146
> +    if (m_loadingErrorPage)
> +        return;
> +
> +    notifyStatus(m_frame, WEBKIT_LOAD_FAILED);
> +

And here.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.