[Webkit-unassigned] [Bug 48053] Make http locking default in NRWT

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=48053


Ojan Vafai <ojan at chromium.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #71413|review?                     |review-
               Flag|                            |




--- Comment #2 from Ojan Vafai <ojan at chromium.org>  2010-10-21 09:01:44 PST ---
(From update of attachment 71413)
View in context: https://bugs.webkit.org/attachment.cgi?id=71413&action=review

Should we remove start/stop server calls from run_webkit_tests.py as well? Seems like we should only need to do this in dump_render_tree_thread, right?

> WebKitTools/Scripts/webkitpy/layout_tests/port/base.py:587
> +    def start_servers_to_lock(self):
> +        self.start_http_server()
> +        self.start_websocket_server()
> +
> +    def stop_servers_to_lock(self):
> +        self.stop_http_server()
> +        self.stop_websocket_server()

Can we move the acquire_http_lock and release_http_lock calls into these functions? And maybe rename them to start_servers_with_lock/stop_servers_with_lock?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.