[Webkit-unassigned] [Bug 46029] [EFL] add pango support

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=46029





--- Comment #6 from Rafael Antognolli <antognolli at profusion.mobi>  2010-10-21 06:29:38 PST ---
(In reply to comment #5)
> (In reply to comment #4)
> > Created an attachment (id=68844)
 --> (https://bugs.webkit.org/attachment.cgi?id=68844&action=review) [details] [details]
> > Patch
> 
> I moved FIND_PACKAGE(Freetype).

(In reply to comment #4)
> Created an attachment (id=68844)
 --> (https://bugs.webkit.org/attachment.cgi?id=68844&action=review) [details]
> Patch

(In reply to comment #3)
> (In reply to comment #2)
> > Hi Ryuan,
> > 
> > Do you really need to include the gtk directory here?
> > 
> > +IF (WTF_USE_PANGO)
> > +  LIST(APPEND WebKit_INCLUDE_DIRECTORIES
> > +    "${WEBCORE_DIR}/platform/graphics/gtk"
> > +    ${Pango_INCLUDE_DIRS}
> > +  )
> > +  LIST(APPEND WebKit_LIBRARIES
> > +    ${Pango_LIBRARIES}
> > 
> 
> sorry about late answer.
> now, Pango related implementation was in platform/graphics/gtk.
> unless moving it, we should include it.

Ok, I understand your point, but would be better to have these files inside somewhere else (maybe platform/graphics/pango?).

Anyway, I think it's ok for now.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.