[Webkit-unassigned] [Bug 47839] JSC interpreter regressions after r69940

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=47839





--- Comment #1 from Zoltan Herczeg <zherczeg at webkit.org>  2010-10-21 01:13:12 PST ---
Bug:

JSValue result = JSC::resolveBase(callFrame, ident, callFrame->scopeChain(), isStrictPut);
if (!result) {
    callFrame->r(dst) = result;
    ASSERT(callFrame->r(dst).jsValue());
} else
    callFrame->globalData().exception = createErrorForInvalidGlobalAssignment(callFrame, ident.ustring());

"if (!result)" is wrong, because it should test the opposite. Although "if (!!result)" is ok, I refactored the code with "UNLIKELY(!result)".

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.