[Webkit-unassigned] [Bug 48041] New: `webkit-patch upload` runs git-diff at least 3 times, which is slow

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Oct 20 22:36:59 PDT 2010


https://bugs.webkit.org/show_bug.cgi?id=48041

           Summary: `webkit-patch upload` runs git-diff at least 3 times,
                    which is slow
           Product: WebKit
           Version: 528+ (Nightly build)
          Platform: All
        OS/Version: All
            Status: NEW
          Severity: Normal
          Priority: P2
         Component: Tools / Tests
        AssignedTo: webkit-unassigned at lists.webkit.org
        ReportedBy: aroben at apple.com
                CC: eric at webkit.org, abarth at webkit.org


`webkit-patch upload` runs git-diff at least 3 times:

1) when finding ChangeLogs to parse for bug IDs
2) when running check-webkit-style (I think)
3) when creating the diff to present to the user for confirmation

There might be other instances of git-diff that I've missed.

It would be faster if we could just run git-diff once.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list