[Webkit-unassigned] [Bug 47174] Moving all bounding box related calculation to RenderSVGResourceFilterPrimitive

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=47174


Dirk Schulze <krit at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #71283|review?                     |review-
               Flag|                            |




--- Comment #8 from Dirk Schulze <krit at webkit.org>  2010-10-20 13:34:17 PST ---
(From update of attachment 71283)
View in context: https://bugs.webkit.org/attachment.cgi?id=71283&action=review

Just style issues remaining. Great Patch! Looking forward to see a fixed version of this patch and a followup with turning determineFilterPrimitiveSubregion into a member of the Renderer. r- for now.

> WebCore/platform/graphics/filters/ImageBufferFilter.h:-46
> -    virtual FloatSize maxImageSize() const { return FloatSize(); }

This file doesn't exist any longer. Revert this file in your local copy and update to trunk. Shouldn't cause any problems.

> WebCore/rendering/RenderSVGResourceFilterPrimitive.cpp:39
> +    FloatRect subRegionBoundingBox = effect->effectBoundaries();
> +    FloatRect newSubRegion = subRegionBoundingBox;

We use just subregion, not subRegion now.

> WebCore/rendering/RenderSVGResourceFilterPrimitive.cpp:49
> +    }
> +    else {

} else {

> WebCore/rendering/RenderSVGResourceFilterPrimitive.h:46
> +    // These two arguments are depend on the RenderObject

s/depend/dependent/ or just they depend on...

> WebCore/svg/graphics/filters/SVGFilter.cpp:@
>  SVGFilter::SVGFilter(const AffineTransform& absoluteTransform, const FloatRect&

Remove the SVGFEImage.h include in this file.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.