[Webkit-unassigned] [Bug 48002] network-simulator.php makes for very slow layout tests

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Oct 20 13:29:04 PDT 2010


https://bugs.webkit.org/show_bug.cgi?id=48002





--- Comment #2 from Michael Nordman <michaeln at google.com>  2010-10-20 13:29:04 PST ---
(In reply to comment #1)
> This script simulates a disconnected network, as well as we can. Sending an error response would test something different.

Yes, I see what it's doing and why. The fact remains that we have tests that timeout due to this.

I question whether we need to simulate a network error in all the places where this script is used. It looks like a http error would effectively test the logic that wants to be tested. I'm looking thru the appcache tests and noticing that simulated network errors are used thruout, but haven't really noticed (m)any tests that simulate a server error.

Also, I question whether this is as good of a simulation of a network error as can be constructed. I wonder if we can close the underlying connection from the server-side?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list