[Webkit-unassigned] [Bug 47990] [GTK] Replace encodings multi-dimensional array with calls to registrar method

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=47990


Martin Robinson <mrobinson at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #71300|review?                     |review-
               Flag|                            |




--- Comment #2 from Martin Robinson <mrobinson at webkit.org>  2010-10-20 12:28:11 PST ---
(From update of attachment 71300)
View in context: https://bugs.webkit.org/attachment.cgi?id=71300&action=review

I love this patch. Just a couple small nits.

> WebCore/platform/text/gtk/TextCodecGtk.cpp:92
> +bool TextCodecGtk::registerEncodingAliasIfAvailable(EncodingNameRegistrar registrar, const char* canonicalName, const char* aliasName)

It looks like you never check the return value of this method. Can it just return void?

> WebCore/platform/text/gtk/TextCodecGtk.h:60
> +        static bool registerEncodingNameIfAvailable(EncodingNameRegistrar registrar, const char* canonicalName);
> +        static bool registerEncodingAliasIfAvailable(EncodingNameRegistrar registrar, const char* canonicalName, const char* aliasName);
> +        static void registerCodecIfAvailable(TextCodecRegistrar registrar, const char* codecName);
>  

Could these these can just be static functions in TextCodecGtk.cpp?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.