[Webkit-unassigned] [Bug 47810] [HTML5] Add DOMSettableTokenList

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=47810


Kent Tamura <tkent at chromium.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #71255|review?                     |review-
               Flag|                            |




--- Comment #14 from Kent Tamura <tkent at chromium.org>  2010-10-20 08:17:10 PST ---
(From update of attachment 71255)
View in context: https://bugs.webkit.org/attachment.cgi?id=71255&action=review

I think WebCore/Android.mk and WebCore/CMakeList.txt need to have ClassLis.cpp.

> WebCore/ChangeLog:12
> +        * Android.derived.jscbindings.mk:

You should add a comment to each of files/functions in ChangeLog as possible.
In this case, you can add comments like
 - "Add <new files>" for build files
 - "Moved from Foobar.cpp" for copied functions
Such comments would be very helpful for reviewing.

> WebCore/bindings/v8/custom/V8DOMSettableTokenListCustom.cpp:37
> +    // TODO(bashi): Implement this function.

We don't use TODO(username): style in WebKit.  Just put FIXME: please.

> WebCore/dom/SpaceSplitString.h:79
> +        void add(const AtomicString& string) { if (m_data) m_data->add(string); }

Please move the implementation to SpaceSplitString.cpp.

> WebCore/dom/SpaceSplitString.h:80
> +        void remove(const AtomicString& string) { if (m_data) m_data->remove(string); }

ditto.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.