[Webkit-unassigned] [Bug 47969] New: Unify globalData APIs

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=47969

           Summary: Unify globalData APIs
           Product: WebKit
           Version: 528+ (Nightly build)
          Platform: PC
        OS/Version: Mac OS X 10.5
            Status: NEW
          Severity: Normal
          Priority: P2
         Component: JavaScriptCore
        AssignedTo: webkit-unassigned at lists.webkit.org
        ReportedBy: xan.lopez at gmail.com


The globalData getter in JSGlobalObject returns a pointer, while the one in CallFrame.h returns a reference. There was a FIXME in CallFrame.h suggesting to unify them, so the attached patch does that.

I wasn't completely sure of which way to go with this, but after some googling I decided to move the getter in JSGlobalObject to return a reference, since it seems it's the preferred thing to do in the public API of classes when there's no need to, say, return NULL in special cases.

There's no change in the tests or significant change in SunSpider.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.