[Webkit-unassigned] [Bug 45716] [BREWMP] Port unicode

Tue Oct 19 17:51:27 PDT 2010

https://bugs.webkit.org/show_bug.cgi?id=45716

--- Comment #13 from Kwang Yul Seo <kwangyul.seo at gmail.com>  2010-10-19 17:51:27 PST ---
(In reply to comment #12)
> Do you think we can share the implementation between BREWMP and WinCE?

Yes, I just copied the implementation of WinCE only with minor style changes.

> Do you have an example of "UnicodeFromICU.h"? Is it a "copy" of ce_unicode.h|cpp?
> (I'm not very happy with the current WinCE implementation, maybe we can do it better)

Yes, it is just a copy of ce_unicode.h|cpp with slight changes.

> 
> IMHO we can share the implementaions as a "UnicodeMinimalCopyOfICU". I don't think that there's something BREW specific in this files.
> 

I agree. There is no Brew MP specific code in these files.

> PS: Use "svn cp" if you copy UnicodeBrew from UnicodeWinCE. This helps when looking at the history.

Thanks for the tip.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.