[Webkit-unassigned] [Bug 47629] Moving cursor back to autocorrected word in the same line shouldn't remove the underline

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=47629





--- Comment #16 from jpu at apple.com  2010-10-19 15:19:35 PST ---
(In reply to comment #14)
> (In reply to comment #11)
> > (In reply to comment #10)
> > > It appears this only affects chromium mac, not Safari or chromium on other platforms.
> > I think, instead of:
> > 
> > #if PLATFORM(MAC) && (defined(BUILDING_ON_TIGER) || defined(BUILDING_ON_LEOPARD) || defined(BUILDING_ON_SNOW_LEOPARD))
> > 
> > I should add:
> > 
> > #if !PLATFORM(MAC) || (PLATFORM(MAC) && (defined(BUILDING_ON_TIGER) || defined(BUILDING_ON_LEOPARD) || defined(BUILDING_ON_SNOW_LEOPARD)))
> > 
> > This way, it only changes the behavior in Safari on 10.7. Shall I create a separate bug for this, or adding another path in this bug?
> 
> SGTM.
> 
> But did you get comment about there's a code that adds correction indicator that's outside of ifdef's?
> http://trac.webkit.org/browser/trunk/WebCore/editing/Editor.cpp?rev=70071#L2788
> 
> Could you verify that this is intended?

The CorrectionIndicator marker isn't used except in Safari on 10.7. But, for the sake of clarity, I suppose I should put that statement inside "#if PLATFORM(MAC) && !defined(BUILDING_ON_TIGER) && !defined(BUILDING_ON_LEOPARD) && !defined(BUILDING_ON_SNOW_LEOPARD)"

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.