[Webkit-unassigned] [Bug 42578] [Qt] DRT sideeffect revealed by r63657

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=42578





--- Comment #19 from Robert Hogan <robert at webkit.org>  2010-10-19 14:06:58 PST ---
(In reply to comment #17)
> (In reply to comment #16)
> > 8 tests fail:
> > 
> > http/tests/navigation/error404-basic.html
> > http/tests/navigation/error404-goback.html
> > http/tests/navigation/error404-subframeload.html
> > http/tests/navigation/javascriptlink-frames.html
> > http/tests/navigation/postredirect-basic.html
> > http/tests/navigation/postredirect-frames.html
> > http/tests/navigation/postredirect-goback1.html
> > http/tests/security/mixedContent/insecure-css-in-main-frame.html
> >
> >
> > The navigation tests seem to have wrong expected results, the security test was flakey before, now it seems to fail always.

The differences are all rendertext-related rather than 'real' differences. Strange.

> 
> I can confirm. I tried to run navigation tests with --singly option
> and I got same fails as after this patch. When the fix for this
> sideeffect bug landed, we have to update expected results. 
> 
> http/tests/security/mixedContent/insecure-css-in-main-frame.html is
> flakey because of a sideeffect, which will be fixed by this patch.
> To make it pass we have to remove the Qt specific wrong expected result:
> LayoutTests/platform/qt/http/tests/security/mixedContent/insecure-css-in-main-frame-expected.txt
> 
> I worry about the performance regression a little bit. Can we make it faster?

This was the only way I could think of.

I'll update per Andras' comment and commit over the weekend if r+'d. That will allow me to time to watch the failures, if any, on the bot and correct them.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.