[Webkit-unassigned] [Bug 47879] FAIL: test_reset_results (webkitpy.layout_tests.run_webkit_tests_unittest.RebaselineTest)

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=47879





--- Comment #13 from Dirk Pranke <dpranke at chromium.org>  2010-10-19 14:00:10 PST ---
(In reply to comment #12)
> > Sorry about the breakage.
> 
> No problem.  We all break things.
> 
> > Adam, do you want to complete the review? Dirk's changes look like an improvement to me even though there's a remaining FIXME about fully virtualizing the file system for these unit tests.
> 
> I'm not that excited about the patch because it doesn't fix the underlying problem, but someone else should feel free to review it.

Well, I wouldn't go that far. (a) it's not 100% clear what caused this test to fail, since none of us have been able to reproduce it locally. (b) the test was definitely broken in one way, in that stuff was getting written out when it shouldn't have been. That is now fixed.

It is true that there are still places where things get written out, but they're not places that are going to cause this test to fail, so I'm as sure as I can be that it's fixed without being able to reproduce the exact failure.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.