[Webkit-unassigned] [Bug 45457] [Qt] QtTestBrowser is crashing on www.index.hu

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=45457





--- Comment #16 from Oliver Hunt <oliver at apple.com>  2010-10-19 12:23:45 PST ---
(In reply to comment #15)
> (In reply to comment #12)
> > (In reply to comment #11)
> > > Running the test through 'jsc' yields some interesting valgrind output:
> > > 
> > > ==19191== Conditional jump or move depends on uninitialised value(s)
> > > ==19191==    at 0x428401: JSC::BytecodeGenerator::emitOpcode(JSC::OpcodeID) (BytecodeGenerator.cpp:678)
> > 
> > I looked at this briefly and it looks like m_lastOpcodePosition is only initialised in one constructor.  If you put up a patch to fix this i'll review.
> > 
> > The ProgramNode constructor has this
> > 
> >     , m_lastOpcodeID(op_end)
> > #ifndef NDEBUG
> >     , m_lastOpcodePosition(0)
> > #endif
> > 
> > But the other versions don't have the
> > #ifndef NDEBUG
> >     , m_lastOpcodePosition(0)
> > #endif
> > 
> > bit.
> > 
> > Adding that should get valgrind past this uninitialised var so we can see if it picks up anything else.
> 
> I tried it locally, but I got similar crash and backtrace.
> But these uninitialized members are real bugs. I'll upload
> a patch to fix them soon.

Oh sorry, I wasn't clear enough -- i knew these weren't the bug, but i figured silencing valgrind warnings == win.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.