[Webkit-unassigned] [Bug 47877] [chromium] DumpRenderTree shouldn't put '.' in include path

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=47877





--- Comment #7 from Tony Chang <tony at chromium.org>  2010-10-19 09:33:49 PST ---
(In reply to comment #5)
> Either is possible. That said, should I have to run update-webkit --chromium before I can build src/webkit/webkit.gyp ? Is this something weird because I have a webkit checkout that gclient sync normally takes care of?

You only need to run update-webkit --chromium if you want to build as a webkit only checkout (e.g., if you want to use build-webkit --chromium).  This is only a problem for people who have previously run update-webkit --chromium in their third_party/WebKit directory.

> Or does the code have logic to only try and build DRT if there is an upstream checkout, and so people who don't have upstream checkouts don't hit this?

The gyp files will always try to build DRT, however, some of the include paths are different depending on whether you're building with a chromium checkout or if you're using build-webkit --chromium.  The bug was that we weren't making the include path sensitive to those differences.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.