[Webkit-unassigned] [Bug 47903] [EFL] Sets default user agent

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=47903


Leandro Pereira <leandro at profusion.mobi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #71169|commit-queue?               |commit-queue-
               Flag|                            |




--- Comment #3 from Leandro Pereira <leandro at profusion.mobi>  2010-10-19 08:44:38 PST ---
(From update of attachment 71169)
View in context: https://bugs.webkit.org/attachment.cgi?id=71169&action=review

Patch looks fine otherwise. Fix the style issues and other comments and you get my informal r+ :)

> WebKit/efl/ewk/ewk_settings.cpp:80
> +        uaOSVersion = eina_stringshare_add("Unknown");

Please follow the coding style here:

if (condition) {
  statement1;
  statement2;
} else
  statement3;

> WebKit/efl/ewk/ewk_version.h:37
> +#endif

These version macros should be set in cmakeconfig.h, so there's only one place to set the EWebKit version.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.