[Webkit-unassigned] [Bug 47716] [Qt] WebKit2 history, QWKHistory

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=47716


Kenneth Rohde Christiansen <kenneth at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #71146|review?, commit-queue?      |review-
               Flag|                            |




--- Comment #9 from Kenneth Rohde Christiansen <kenneth at webkit.org>  2010-10-19 06:40:07 PST ---
(From update of attachment 71146)
View in context: https://bugs.webkit.org/attachment.cgi?id=71146&action=review

Almost there!

> WebKit2/UIProcess/API/qt/qwkhistory.h:45
> +    QWKHistory(QWKHistoryPrivate* historyPrivate);

Please leave this as QWKHistory(); Just make it a friend and you can set the d pointer manually.

> WebKit2/UIProcess/API/qt/qwkpage.cpp:486
> +    return d->m_history;

in privates we do not add m_.

> WebKit2/UIProcess/API/qt/qwkpage_p.h:88
> +    QWKHistory* m_history;

make this QWKHistory* history;

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.