[Webkit-unassigned] [Bug 47810] [HTML5] Add DOMSettableTokenList

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=47810





--- Comment #8 from Kenichi Ishibashi <bashi at google.com>  2010-10-19 03:21:05 PST ---
(In reply to comment #5)
Hi Erik,

> > WebCore/html/DOMSettableTokenList.cpp:87
> > +        remove(token, ec);
> 
> This causes another validation. Please refactor to use an internal remove so that we do not validate twice.

Done.

> I don't think this is correct. DOMTokenList has a pretty stupid API that requires that whitespace be preserved.
> 
> For example
> 
> tokenList = 'a   b c'
> tokenList.remove('c')
> assertEquals(tokenList.toString(), 'a   b');

Thank you for letting me know that. I didn't realize such behavior. I've changed the code to save the original value to follow the requirement.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.