[Webkit-unassigned] [Bug 47877] New: [chromium] DumpRenderTree shouldn't put '.' in include path

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=47877

           Summary: [chromium] DumpRenderTree shouldn't put '.' in include
                    path
           Product: WebKit
           Version: 528+ (Nightly build)
          Platform: PC
        OS/Version: Mac OS X 10.5
            Status: NEW
          Severity: Normal
          Priority: P2
         Component: Tools / Tests
        AssignedTo: webkit-unassigned at lists.webkit.org
        ReportedBy: tony at chromium.org
                CC: dpranke at chromium.org, tkent at chromium.org


Dirk was having problems compiling in a chromium checkout that also has an upstream checkout.  The problem is in WebKit.gyp in the DumpRenderTree target.  It adds "." to include_dirs.  When a file in DumpRenderTree tries to include e.g., webkit/support/webkit_support.h, it ends up including the file from third_party/WebKit/WebKit/chromium/webkit/support rather than from webkit/support.

We can fix this by replacing '.' in the include path with '<(chromium_src_dir)'.  I had to do this of the TestNetscapePlugin target.  The problem right now is that DRT tries to include WebKit api files from public/.  So we need to replace the #include lines to not include public and add public to the include dirs.  That should be consistent with how the other targets in WebKit work.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.