[Webkit-unassigned] [Bug 47629] Moving cursor back to autocorrected word in the same line shouldn't remove the underline

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=47629





--- Comment #5 from jpu at apple.com  2010-10-18 17:37:54 PST ---
(In reply to comment #4)
> (From update of attachment 71088 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=71088&action=review
> 
> >>> WebCore/editing/Editor.cpp:-3616
> >>> -            m_frame->document()->markers()->removeMarkers(wordRange.get(), DocumentMarker::CorrectionIndicator);
> >> 
> >> Why remove this line?
> > 
> > This marker value doesn't get added on SnowLeopard or earlier. So, since now this couple lines of code is only for SL or earlier OS, we don't need to remove this marker here anymore.
> 
> Ah, ok.  It looks like before recent changes, there was a call to removeMarkers for DocumentMarker::Replacement.  Does that need to be re-added?

There's no need to add that. The statement for removing Replacement is also part of the patch for adding autocorrection support. But later on, I replaced "Replacement" with "CorrectionIndicator".

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.