[Webkit-unassigned] [Bug 47810] [HTML5] Add DOMSettableTokenList

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=47810





--- Comment #5 from Erik Arvidsson <arv at chromium.org>  2010-10-18 16:20:57 PST ---
(From update of attachment 71026)
View in context: https://bugs.webkit.org/attachment.cgi?id=71026&action=review

> WebCore/html/DOMSettableTokenList.cpp:87
> +        remove(token, ec);

This causes another validation. Please refactor to use an internal remove so that we do not validate twice.

> WebCore/html/DOMSettableTokenList.cpp:103
> +        builder.append(' ');

I don't think this is correct. DOMTokenList has a pretty stupid API that requires that whitespace be preserved.

For example

tokenList = 'a   b c'
tokenList.remove('c')
assertEquals(tokenList.toString(), 'a   b');

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.