[Webkit-unassigned] [Bug 42578] [Qt] DRT sideeffect revealed by r63657

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=42578





--- Comment #13 from Andras Becsi <abecsi at webkit.org>  2010-10-18 14:24:10 PST ---
(From update of attachment 71072)
View in context: https://bugs.webkit.org/attachment.cgi?id=71072&action=review

> WebKitTools/DumpRenderTree/qt/DumpRenderTreeQt.cpp:509
> +    // create our primary testing page/view.
> +    if (isGraphicsBased()) {
> +        m_page = new WebPage(static_cast<QWebView*>(m_mainView), this);
> +        static_cast<QWebView*>(m_mainView)->setPage(m_page);
> +    } else {
> +        m_page = new WebPage(static_cast<QWebView*>(m_mainView), this);
> +        static_cast<QWebView*>(m_mainView)->setPage(m_page);
> +    }

The two paths are the same (copy-paste). I think the test for isGraphicsBased() can be omitted here.
LGTM otherwise. If Ossy hasn't the time to check this on the bot environment, I'll do it tomorrow.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.