[Webkit-unassigned] [Bug 47817] FrameLoader::IsProcessingUserGesture is true for JavaScript initiated downloads after click navigation to webpage
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Mon Oct 18 14:00:10 PDT 2010
https://bugs.webkit.org/show_bug.cgi?id=47817
--- Comment #11 from Johnny Ding <jnd at chromium.org> 2010-10-18 14:00:10 PST ---
(In reply to comment #8)
> Yeah, I think a UI test is ok in this case... I'm not sure how we could test it in DumpRenderTree...
I figured out a way to test it in DumpRenderTree on all ports.
We call LayoutController::dumpFrameLoadCallbacks() to dump the frame info when calling didStartProvisionalLoad logic. Please refer to (only lists mac/chromium ports)
1. https://svn.webkit.org/browser/trunk/WebKitTools/DumpRenderTree/chromium/WebViewHost.cpp#L1290
2. https://svn.webkit.org/browser/trunk/WebKitTools/DumpRenderTree/mac/FrameLoadDelegate.mm#L143
In the dump implementation, we output the gesture status of main frame. Please refer to (only lists mac/chromium ports)
1. https://svn.webkit.org/browser/trunk/WebKitTools/DumpRenderTree/chromium/WebViewHost.cpp#L841
2. https://svn.webkit.org/browser/trunk/WebKitTools/DumpRenderTree/mac/FrameLoadDelegate.mm#L76
Since the way needs to change a few DumpRenderTree files, I'd like file another bug to address the test issue and only provide the code patch in here.
Adam, does it make sense to you?
--
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
More information about the webkit-unassigned
mailing list