[Webkit-unassigned] [Bug 47623] Add AudioResampler files

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=47623





--- Comment #4 from Chris Rogers <crogers at google.com>  2010-10-18 12:49:10 PST ---
(From update of attachment 70665)
View in context: https://bugs.webkit.org/attachment.cgi?id=70665&action=review

>> WebCore/platform/audio/AudioResampler.cpp:105
>> +    for (unsigned i = 0; i < m_kernels.size(); ++i) {
> 
> dont' call a method within a loop. initialize the length outside the loop

FIXED

>> WebCore/platform/audio/AudioResampler.cpp:121
>> +    for (unsigned i = 0; i < m_kernels.size(); ++i)
> 
> same here as above

FIXED

>> WebCore/platform/audio/AudioResampler.h:41
>> +    AudioResampler(); // default to mono
> 
> This comment seems like it should be in the class description above, not inline.

FIXED: moved comment

>> WebCore/platform/audio/AudioResampler.h:53
>> +    // 0 < rate <= MaxRate
> 
> seems like MaxRate should be in the header so that clients could use the max rate if they so desired.

It *is* declared a few lines after this

>> WebCore/platform/audio/AudioResampler.h:59
>> +protected:
> 
> should probably be private

FIXED

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.