[Webkit-unassigned] [Bug 47716] [Qt] WebKit2 history, QWKHistory

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=47716


Kenneth Rohde Christiansen <kenneth at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #71013|review?, commit-queue?      |review-
               Flag|                            |




--- Comment #7 from Kenneth Rohde Christiansen <kenneth at webkit.org>  2010-10-18 12:19:08 PST ---
(From update of attachment 71013)
View in context: https://bugs.webkit.org/attachment.cgi?id=71013&action=review

> WebKit2/UIProcess/API/qt/qwkhistory.cpp:39
> +QWKHistory::QWKHistory(WebKit::WebBackForwardList* list)

This is not BC compatible. Our public classes (even in private: section) cannot refer to WebCore / WebKit internals

> WebKit2/UIProcess/API/qt/qwkhistory.h:49
> +    WebKit::WebBackForwardList* m_backForwardList;

This class should take a QWKHistoryPrivate* d pointer, and the WebKit::WebBackForwardList* should be inside that private class.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.