[Webkit-unassigned] [Bug 32492] Missing support for document.createEvent("OrientationEvent")

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=32492





--- Comment #6 from Yongjun Zhang <yongjun_zhang at apple.com>  2010-10-18 09:37:39 PST ---
(In reply to comment #5)
> (From update of attachment 70874 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=70874&action=review
> 
> > LayoutTests/fast/dom/DeviceOrientation/create-event-onorientationchange-expected.txt:11
> > +Tests that document.createEvent() works with orientationChange
> > +
> > +On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
> > +
> > +
> > +
> > +
> > +
> > +PASS successfullyParsed is true
> > +
> > +TEST COMPLETE
> 
> This is rather blank. There is no PASS / FAIL message in the common case.
> 
> > LayoutTests/fast/dom/DeviceOrientation/script-tests/create-event-onorientationchange.js:15
> > +try {
> > +    var event = document.createEvent("OrientationEvent");
> > +    event.initEvent("orientationchange", false, false);
> > +    window.dispatchEvent(event);
> > +} catch(e) {
> > +}
> 
> I would suggest outputting something in the catch { ... } along the lines of
> "Orientation Events don't appear to be enabled or implemented".
> 
> I don't know the best way to reduce the overhead of submitting a test which
> will only pass behind an ENABLE flag.

thanks for the comments.  Folder fast/dom/DeviceOrientation/ is skipped for most ports, and for those ports (Android?) that enabled device orientation events but not onorientationchange, this test will fail by default, hence the failed result as expected result.   The port need to override the expected result if onorientationchange is implemented.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.