[Webkit-unassigned] [Bug 46973] Need to swap glyphs for vertical writing

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=46973





--- Comment #21 from Takumi Takano <takano1 at asia.apple.com>  2010-10-18 05:10:01 PST ---
Thank you very much for your feedback again. I've fixed them except following two.

> > WebCore/platform/graphics/cocoa/FontPlatformData.h:62
> > +    FontPlatformData(float size, bool syntheticBold, bool syntheticOblique, FontOrientation fontOrientation = Horizontal)
> 
> I’m not sure it’s a good idea to have a default value for the orientation.
> 

Otherwise CachedFont.cpp:124, FontCache.cpp:241, SimpleFontData.cpp:67 cause compile errors on FontPlatformData creation as now we don't add "orientation" to non-Mac platform. Or, do you think it is better to add another constructor that takes only a size, a bold flag, and an oblique flag?


> > WebCore/platform/graphics/mac/GlyphPageTreeNodeMac.cpp:77
> > +            RetainPtr<CGFontRef> runCGFont(AdoptCF, CTFontCopyGraphicsFont(runFont, 0));
> > +            if (CFEqual(fontData->platformData().cgFont(), runCGFont.get())) {
> 
> Is there a reason to compare CGFonts and not CTFonts here?
> 

CFEqual for CTFont considers font's CTFontDescriptor that contains various attributes on top of the font data itself. I wanted to avoid possible small discrepancies CT's layout engine might added.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.