[Webkit-unassigned] [Bug 47805] [GTK] Tests LayoutTests/fast/encoding/utf-32* fail when using glib unicode

Mon Oct 18 02:49:36 PDT 2010

https://bugs.webkit.org/show_bug.cgi?id=47805

WebKit Review Bot <webkit.review.bot at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |webkit.review.bot at gmail.com

--- Comment #2 from WebKit Review Bot <webkit.review.bot at gmail.com>  2010-10-18 02:49:36 PST ---
Attachment 71011 did not pass style-queue:

Failed to run "['WebKitTools/Scripts/check-webkit-style']" exit_code: 1
WebCore/platform/text/gtk/TextCodecGtk.h:72:  m_codecAliases_UTF_32 is incorrectly named. Don't use underscores in your identifier names.  [readability/naming] [4]
WebCore/platform/text/gtk/TextCodecGtk.h:73:  m_codecAliases_UTF_32BE is incorrectly named. Don't use underscores in your identifier names.  [readability/naming] [4]
WebCore/platform/text/gtk/TextCodecGtk.h:74:  m_codecAliases_UTF_32LE is incorrectly named. Don't use underscores in your identifier names.  [readability/naming] [4]
WebCore/platform/text/gtk/TextCodecGtk.cpp:59:  TextCodecGtk::m_codecAliases_UTF_8 is incorrectly named. Don't use underscores in your identifier names.  [readability/naming] [4]
WebCore/platform/text/gtk/TextCodecGtk.cpp:60:  TextCodecGtk::m_codecAliases_UTF_32 is incorrectly named. Don't use underscores in your identifier names.  [readability/naming] [4]
WebCore/platform/text/gtk/TextCodecGtk.cpp:61:  TextCodecGtk::m_codecAliases_UTF_32BE is incorrectly named. Don't use underscores in your identifier names.  [readability/naming] [4]
WebCore/platform/text/gtk/TextCodecGtk.cpp:62:  TextCodecGtk::m_codecAliases_UTF_32LE is incorrectly named. Don't use underscores in your identifier names.  [readability/naming] [4]
Total errors found: 7 in 3 files

If any of these errors are false positives, please file a bug against check-webkit-style.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.