[Webkit-unassigned] [Bug 47623] Add AudioResampler files

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=47623


chris fleizach <cfleizach at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #70665|review?                     |review-
               Flag|                            |




--- Comment #2 from chris fleizach <cfleizach at apple.com>  2010-10-18 00:43:58 PST ---
(From update of attachment 70665)
View in context: https://bugs.webkit.org/attachment.cgi?id=70665&action=review

> WebCore/platform/audio/AudioResampler.cpp:105
> +    for (unsigned i = 0; i < m_kernels.size(); ++i) {

dont' call a method within a loop. initialize the length outside the loop

> WebCore/platform/audio/AudioResampler.cpp:121
> +    for (unsigned i = 0; i < m_kernels.size(); ++i)

same here as above

> WebCore/platform/audio/AudioResampler.h:41
> +    AudioResampler(); // default to mono

This comment seems like it should be in the class description above, not inline.

> WebCore/platform/audio/AudioResampler.h:53
> +    // 0 < rate <= MaxRate

seems like MaxRate should be in the header so that clients could use the max rate if they so desired.

> WebCore/platform/audio/AudioResampler.h:59
> +protected:

should probably be private

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.