[Webkit-unassigned] [Bug 47797] New: Clean up of iframe scrollbar mode code

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sun Oct 17 23:00:07 PDT 2010


https://bugs.webkit.org/show_bug.cgi?id=47797

           Summary: Clean up of iframe scrollbar mode code
           Product: WebKit
           Version: 528+ (Nightly build)
          Platform: All
        OS/Version: Mac OS X 10.5
            Status: UNCONFIRMED
          Severity: Normal
          Priority: P2
         Component: WebCore Misc.
        AssignedTo: webkit-unassigned at lists.webkit.org
        ReportedBy: mikelawther at chromium.org


Followup to comments in https://bugs.webkit.org/show_bug.cgi?id=29240#c19 

"Some comments... seems like it would be cleaner to turn off scrollbars early and bail in the helper function rather than doing it at the very end.  That way you're not flipping stuff on and off.

In order to do that, though, you need to pull the setChildNeedsLayout/setNeedsLayout calls (which should never have been put in this code in the first place) out of the helper function and back into the main layout method.

None of this is minus-worthy, though, so could be fixed in a followup."

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list