[Webkit-unassigned] [Bug 47732] [chromium] FontLinux.cpp cleanup (move most methods in TextRunWorker from inlined)

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=47732


David Levin <levin at chromium.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #70888|review?                     |review+
               Flag|                            |




--- Comment #2 from David Levin <levin at chromium.org>  2010-10-16 12:07:18 PST ---
(From update of attachment 70888)
View in context: https://bugs.webkit.org/attachment.cgi?id=70888&action=review

Please consider addressing my comments on landing.

> WebCore/platform/graphics/chromium/FontLinux.cpp:164
> +    TextRunWalker(const TextRun& run, unsigned startingX, const Font* font);

Remove param names that add no information: "run", "font".

> WebCore/platform/graphics/chromium/FontLinux.cpp:167
> +    bool isWordBreak(unsigned i, bool isRTL);

What is "i? In its current form, I'd remove it, but I have no idea what that param is. Should it be called index?

> WebCore/platform/graphics/chromium/FontLinux.cpp:170
> +    void setPadding(int padding);

No need for "padding". (Since the method name is setPadding and it only takes one parameter.)

> WebCore/platform/graphics/chromium/FontLinux.cpp:172
> +    void setBackwardsIteration(bool isBackwards);

Remove param name.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.