https://bugs.webkit.org/show_bug.cgi?id=46775
Cosmin Truta <ctruta at chromium.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #70263|0 |1
is obsolete| |
Attachment #70263|review?, commit-queue? |
Flag| |
Attachment #70941| |review?, commit-queue?
Flag| |
--- Comment #19 from Cosmin Truta <ctruta at chromium.org> 2010-10-15 18:34:55 PST ---
Created an attachment (id=70941)
--> (https://bugs.webkit.org/attachment.cgi?id=70941&action=review)
Fix and layout test.
Same patch as before, but with the extra ASSERT removed from Element::getBoundingClientRect.
The ASSERT is not necessary, since the following statement will crash unambiguously if renderer() is null. In fact, that particular ASSERT might generate confusion, because one must look carefully to see that it's *not* a precondition.
(Eiffel's "require" and "ensure" clauses come to mind as a neat manner to separate pre- and postconditions from the rest of the assertions. This is useful both for compilation and documentation purposes.)
--
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.