[Webkit-unassigned] [Bug 47310] Implement FileEntrySync.file() in FileSystem API

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=47310





--- Comment #14 from Kinuko Yasuda <kinuko at chromium.org>  2010-10-15 16:18:25 PST ---
View in context: https://bugs.webkit.org/attachment.cgi?id=70787&action=review

>> LayoutTests/fast/filesystem/resources/file-from-file-entry-sync.js:1
>> +if (this.importScripts) {
> 
> Is this resource file only used in worker testing? If so, it would be better to put under filesystem/workers/resources. In addition, you can remove the check for the existence of importScripts.

Makes sense, I put a FIXME comment for now - I'd like to file a separate issue to address this and keep it as is in this patch.

There're some other worker-only resources that are put under filesystem/resources and I want to move them in sync (and it requires chromoium test code change too).

>> LayoutTests/fast/filesystem/resources/file-from-file-entry.js:2
>> +    importScripts('../resources/fs-worker-common.js');
> 
> Do we need to use "../resources"?

Fixed.

>> LayoutTests/fast/filesystem/resources/file-from-file-entry.js:3
>> +    importScripts('../resources/fs-test-util.js');
> 
> ditto.

Removed the line as this file doesn't depend on the file.

>> LayoutTests/fast/filesystem/workers/file-from-file-entry-sync-expected.txt:1
>> +
> 
> Why do we have blank expected result here?

Fixed.

>> WebCore/fileapi/DOMFileSystem.cpp:89
>> +void DOMFileSystem::createFile(const FileEntry* file, PassRefPtr<FileCallback> successCallback, PassRefPtr<ErrorCallback>)
> 
> Please consider renaming 'file' argument to 'fileEntry' to avoid the confusion with the File being created in this method.

Fixed.

>> WebCore/fileapi/DOMFileSystem.h:63
>> +    void createFile(const FileEntry* file, PassRefPtr<FileCallback>, PassRefPtr<ErrorCallback>);
> 
> Please omit 'file' argument.

Fixed.

>> WebCore/fileapi/DOMFileSystemSync.cpp:62
>> +PassRefPtr<File> DOMFileSystemSync::createFile(const FileEntrySync* file, ExceptionCode& ec)
> 
> ditto.

Fixed.

>> WebCore/fileapi/DOMFileSystemSync.h:59
>> +    PassRefPtr<File> createFile(const FileEntrySync* file, ExceptionCode&);
> 
> ditto.

Fixed.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.