[Webkit-unassigned] [Bug 35460] EWS should test patches with r+

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Oct 15 06:25:40 PDT 2010


https://bugs.webkit.org/show_bug.cgi?id=35460





--- Comment #7 from Eric Seidel <eric at webkit.org>  2010-10-15 06:25:40 PST ---
OK.  My current thoughts on design for the EWS feeder queue (which will be used to solve this).

1.  Add a page to queues.webkit.org, which will expose the last status message across all queues for a single patch. (machine readable.  The query probably has to be "all status messages matching this patch id, limited to the last 1000" and then we'll filter for just one of each.  I don't think GQL can do unique/group style queries).
2.  Add a page to queues.webkit.org which allows a bot (or a user) to submit any attachment id to all EWSes (using checkboxes in the form).  (Careful to limit it only to EWSes, but otherwise no error checking.)
3.  Have an EWS feeder pull down all r? patches (and at a less frequent interval, all r+ patches).
4.  The EWS feeder will submit each patch to EWSes after checking the last-status page.  only submitting it to EWSes which either have no status, or the last status is RETRY (this allows a user to submit a patch again after PASS/FAIL, but the bot to only submit when RETRY).
5.  Change /next-patch to remove the patch from the active-work-items, or add a new /patch-completed action to do so.
6. Remove the update-work-items code from the EWS bots.  "Submitting" is a non-destructive action.  Never to we write to the server the entire list of patches to process.  We only add with submit-to-ews and remove with /patch-completed.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list