[Webkit-unassigned] [Bug 46723] webkit_web_navigation_action_get_button() wrong

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=46723


Xan Lopez <xan.lopez at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #70849|                            |review-
               Flag|                            |




--- Comment #4 from Xan Lopez <xan.lopez at gmail.com>  2010-10-15 04:38:19 PST ---
(From update of attachment 70849)
Some comments:

- The text appears twice in the file, you need to fix it in both places.
- Your fix basically is telling a lie, since those are not the DOM values, but the GTK+ ones. I think we should either tell the whole story, or just say that the identifier for the clicked button is returned, leaving it implicit that it's GTK+'s. I'd vote to do the former.
- You need to generate a ChangeLog and set the patch as r? when submitting it. Go over this document (http://webkit.org/coding/contributing.html) quickly, but at the very least I need the ChangeLog to commit your patch :)

Thanks!

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.