[Webkit-unassigned] [Bug 41535] "vertical-align: middle; " not working on a MathML element

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=41535


François Sausset <sausset at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #66662|0                           |1
        is obsolete|                            |
  Attachment #70843|                            |review?, commit-queue?
               Flag|                            |




--- Comment #12 from François Sausset <sausset at gmail.com>  2010-10-15 02:22:36 PST ---
Created an attachment (id=70843)
 --> (https://bugs.webkit.org/attachment.cgi?id=70843&action=review)
Revised patch

I added comments in the code.

About the int cast, it is a workaround for the "almost" zero value returned by CGFontGetXHeight().

I changed the guess to use fAscent (float) instead of m_ascent (int) to avoid the float cast.
The check for fAscent is to avoid an unnecessary computation.

As some tests are modified, it will break the GTK build. Could someone add the GTK test results? Or rebaseline just after landing?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.