[Webkit-unassigned] [Bug 47572] [Chromium] Leak in WebCore::createFontCustomPlatformData

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=47572


Hironori Bono <hbono at chromium.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #70584|0                           |1
        is obsolete|                            |
  Attachment #70835|                            |review?
               Flag|                            |




--- Comment #3 from Hironori Bono <hbono at chromium.org>  2010-10-14 23:09:54 PST ---
Created an attachment (id=70835)
 --> (https://bugs.webkit.org/attachment.cgi?id=70835&action=review)
A quick fix 2

(In reply to comment #2)
> (From update of attachment 70584 [details])
> I would prefer to have Chrome call WebCache::clear() when in valgrind mode.
> I don't think the release product should need to clear the WebCore cache
> at renderer shutdown time.  It is costly to walk the cache and bring all of
> those objects into memory just to free them.  This will make it slower to
> close tabs, etc.

Thank you for your comment. I have added a flag that controls whether we should clean the resources so we can clean them only when we run Chrome or TestShell on valgrind. (I'm going to send a Chromium change that actually sets this flag when running on valgrind.) Is it possible to look the updated one?

Regards,

Hironori Bono

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.