[Webkit-unassigned] [Bug 47689] REGRESSION (r69548): Autocorrections are applied even after typing further characters in the word

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=47689





--- Comment #5 from Darin Adler <darin at apple.com>  2010-10-14 16:18:25 PST ---
(From update of attachment 70794)
View in context: https://bugs.webkit.org/attachment.cgi?id=70794&action=review

It’s not great to name a test after the Apple Radar bug number for the problem. Since people outside Apple have limited or no access to Radar we try to keep the amount of Radar references in the bugs and tests to a minimum. But I suppose we can live with it for a Mac-specific test.

> LayoutTests/platform/mac-tiger/Skipped:213
> +platform/mac/editing/spelling/radar8552250.html
>  \ No newline at end of file

Should include a newline.

> LayoutTests/platform/mac/editing/spelling/radar8552250.html:38
> +    setTimeout("keepTyping()", 1000);

It’s really bad to have a 1 second delay in a regression test. We want the layout tests to run really quickly. There is a debugging machinery for making time move forward quickly: the eventSender.leapForward function. However, if the timing check is in code outside WebKit perhaps that won’t work. You need to at least give that a try.

> LayoutTests/platform/mac/editing/spelling/radar8552250.html:46
> +<div>You should see phrase 'the collapsing' without underline.</div>

How does the test output indicate the lack of the underline? Is there something in the render tree dump that would be there if the underline was present?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.