[Webkit-unassigned] [Bug 47608] Add !SINGLE_THREADED guard.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Oct 14 10:52:55 PDT 2010


https://bugs.webkit.org/show_bug.cgi?id=47608


Alexey Proskuryakov <ap at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |ap at webkit.org,
                   |                            |levin at chromium.org




--- Comment #3 from Alexey Proskuryakov <ap at webkit.org>  2010-10-14 10:52:54 PST ---
There is already ThreadingNone.cpp - and since it's behind ENABLE(SINGLE_THREADED), I expect it to be present in your port. So, the explanation in ChangeLog is misleading.

The reason tryLock() in ThreadingNone.cpp returns false is that we have lots of assertions of this form: ASSERT(!m_databaseGuard.tryLock()).

So, even while yield() can just be added to ThreadingNone.cpp, changing tryLock() to support the logic in this function is more involved. Perhaps the approach in this patch is the right one. David, what do you think?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list