[Webkit-unassigned] [Bug 47033] [GTK] REGRESSION: FreeType backend does not respect XSettings font settings after r68558

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=47033





--- Comment #3 from Holger Freyther <zecke at selfish.org>  2010-10-14 10:46:40 PST ---
(From update of attachment 70129)
View in context: https://bugs.webkit.org/attachment.cgi?id=70129&action=review

The patch looks fine, I have just one minor comment.

> WebCore/ChangeLog:11
> +        override the setting if it was previously off.

Why is that the case? What would happen if we turn it on again?

> WebCore/platform/graphics/cairo/FontPlatformDataFreeType.cpp:93
> +            cairo_font_options_set_antialias(options, CAIRO_ANTIALIAS_GRAY);

The else if comes a bit unexpected. Could you move the comment to the top?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.