[Webkit-unassigned] [Bug 46973] Need to swap glyphs for vertical writing

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=46973





--- Comment #12 from Takumi Takano <takano1 at asia.apple.com>  2010-10-14 04:32:35 PST ---
Thanks for the review.  I'll fix them except following one.

> WebCore/platform/graphics/mac/SimpleFontDataCoreText.cpp:81
....
> Instead of making this change, you should change FontPlatformData::ctFont() to return a font with kCTFontOrientationAttribute set to kCTFontVerticalOrientation.
> 

Apparently CTFont's CTFontGetGlyphsForCharacters() doesn't retrieve vertical variant glyphs even the font has kCTFontVerticalOrientation attribute, probably because glyph swapping for vertical layout is handled in CoreText's line layout engine, not at CTFont's level. I checked the source of CTFontGetGlyphsForCharacters() and confirmed it just directly consults font's cmap.

Can I leave this part as is?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.