[Webkit-unassigned] [Bug 45716] [BREWMP] Port unicode

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Oct 13 17:44:56 PDT 2010


https://bugs.webkit.org/show_bug.cgi?id=45716


Kent Tamura <tkent at chromium.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #70690|review?                     |review+
               Flag|                            |




--- Comment #9 from Kent Tamura <tkent at chromium.org>  2010-10-13 17:44:55 PST ---
(From update of attachment 70690)
View in context: https://bugs.webkit.org/attachment.cgi?id=70690&action=review

> JavaScriptCore/wtf/unicode/brew/UnicodeBrew.cpp:94
> +        remainingCharacters += sourceEnd - sourceIterator;

+= looks curious here.
  int remainingCharacters = sourceIterator < sourceEnd ? sourceEnd - sourceIterator : 0;
would be better.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list