[Webkit-unassigned] [Bug 46105] [BREWMP] Add TextBoundaries and TextBreakIterator

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=46105


Kent Tamura <tkent at chromium.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #68113|review?, commit-queue?      |review+, commit-queue-
               Flag|                            |




--- Comment #2 from Kent Tamura <tkent at chromium.org>  2010-10-13 17:16:54 PST ---
(From update of attachment 68113)
View in context: https://bugs.webkit.org/attachment.cgi?id=68113&action=review

> WebCore/platform/text/brew/TextBoundariesBrew.cpp:37
> +int findNextWordFromIndex(const UChar * buffer, int len, int position, bool forward)

The position of "*" is noncommittal.  We usually use "const UChar* buffer".

> WebCore/platform/text/brew/TextBoundariesBrew.cpp:43
> +void findWordBoundary(const UChar * buffer, int len, int position, int* start, int* end)

ditto.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.