[Webkit-unassigned] [Bug 47518] Add DelayDSPKernel files

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Oct 13 17:13:11 PDT 2010


https://bugs.webkit.org/show_bug.cgi?id=47518


chris fleizach <cfleizach at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |cfleizach at apple.com




--- Comment #7 from chris fleizach <cfleizach at apple.com>  2010-10-13 17:13:11 PST ---
(In reply to comment #4)
> (From update of attachment 70495 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=70495&action=review
> 
> >> WebCore/webaudio/DelayDSPKernel.cpp:43
> >> +    , m_buffer(static_cast<size_t>(processor->sampleRate() * DefaultMaxDelayTime))
> > 
> > do you need to worry about the case where someone calls DelayDSPKernel(0)
> 
> Yes, good point.  I've added extra checks for negative and zero values in this constructor.
> 

In both patches I don't see the extra checks.. Can you point those out

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list