[Webkit-unassigned] [Bug 45716] [BREWMP] Port unicode

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=45716


Kent Tamura <tkent at chromium.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #67490|review?                     |review-
               Flag|                            |




--- Comment #6 from Kent Tamura <tkent at chromium.org>  2010-10-13 17:11:34 PST ---
(From update of attachment 67490)
View in context: https://bugs.webkit.org/attachment.cgi?id=67490&action=review

r- because of style errors.

> JavaScriptCore/wtf/unicode/brew/UnicodeBrew.cpp:84
> +    int remainingCharacters = 0;

remainingCharacters should be declared just before it is used.

> JavaScriptCore/wtf/unicode/brew/UnicodeBrew.cpp:85
> +    if (sourceLength <= resultLength)

You should enclose this block with {} because the block contains two physical lines.

> JavaScriptCore/wtf/unicode/brew/UnicodeBrew.cpp:88
> +    else

ditto.

> JavaScriptCore/wtf/unicode/brew/UnicodeBrew.cpp:101
> +int toUpper(UChar* result, int resultLength, const UChar* source, int sourceLength, bool* isError)

Same comments as toLower().

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.